fix formatting

Why? Let's make this invalid state, as the lower scope is doing nothing?

Because someone may be changing the scope. Scope change is not atomic and we cannot block the entire hierarchy in the meantime.

Inside CQ workloads are selected according to their AdmissionMode (if specified)

Only highest AdmissionScope is used. Do you mean Queueing Policy (FIFO/BestEffort)?

The candidates inside individual CQs are selected based on the specified logic and bubbled up.

IIUC, we already have this field

Yes, there is. I change the meaning a bit to be more generic.

I see. We will change only the meaning, and not change the API's looking. Thanks.

Why not use conditions on each resource instead of this dedicated LastUpdate?
In this approach, I think If we want to add any reason and message for FairShare, we need to add those condition similarity fields here.

Conditions have last transition, not last update.

// lastTransitionTime is the last time the condition transitioned from one status to another.
// This should be when the underlying condition changed. 

Here there is no transition, just updates.

I see. You mean this is the time when kueue takes a snapshot of consumed usage.
In that case, we probably want to say usageSnapshotAt, usageCalculationAt or something so that we can obviously clarify what is this time.

WDYT?

Personally I see LastUpdate time as more straightforward and potentially covering also WeightedShare or whatever else we add in the future. UsageSnapshotAt limits us, and if any new field is added then we will need another timestamp.